Fix phone is not in {, non}silence.txt#1159
Merged
danpovey merged 1 commit intokaldi-asr:masterfrom Oct 31, 2016
aevernon:master
Merged
Fix phone is not in {, non}silence.txt#1159danpovey merged 1 commit intokaldi-asr:masterfrom aevernon:master
danpovey merged 1 commit intokaldi-asr:masterfrom
aevernon:master
Conversation
The latest version of sw-ms98-dict.text from http://www.openslr.org/resources/5/switchboard_word_alignments.tar.gz contains the following header on line 1: file: $SWB/data/dictionary/sw-ms98-dict.text This ends up in lexicon0.txt, which causes utils/validate_dict_dir.pl to fail with the following error: --> ERROR: phone "$swb/data/dictionary/sw-ms98-dict.text" is not in {, non}silence.txt (line 10399) This in turn causes utils/prepare_lang.sh to fail. Update dict.patch so that it removes the file header from sw-ms98-dict.text.
Contributor
|
That line has always been there; I think the regression was caused by some fixes to awk scripts that we made for mawk compatibility. But your fix works, so merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest version of
sw-ms98-dict.textfrom http://www.openslr.org/resources/5/switchboard_word_alignments.tar.gz contains the following header on line 1:This ends up in
lexicon0.txt, which causesutils/validate_dict_dir.pltofail with the following error:
This in turn causes
utils/prepare_lang.shto fail.Update
dict.patchso that it removes the file header fromsw-ms98-dict.text.